Bug 237899 - Suppress warnings for implicit conversion from unsigned long to double
Summary: Suppress warnings for implicit conversion from unsigned long to double
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-15 09:25 PDT by Basuke Suzuki
Modified: 2022-03-16 13:51 PDT (History)
4 users (show)

See Also:

Attachments
PATCH (1.41 KB, patch)
2022-03-16 10:26 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2022-03-15 09:25:29 PDT 
C:/PSDev/neko2/Tools/TestWebKitAPI/Tests/WTF/Int128.cpp:254:71: warning: implicit conversion from 'unsigned long' to 'double' changes value from 13527593555435554952 to 13527593555435554816 [-Wimplicit-const-int-float-conversion]
    double approx_double = 0xffffeeeeddddcccc * std::pow(2.0, 64.0) + 0xbbbbaaaa99998888;
                                                                    ~ ^~~~~~~~~~~~~~~~~~
C:/PSDev/neko2/Tools/TestWebKitAPI/Tests/WTF/Int128.cpp:254:28: warning: implicit conversion from 'unsigned long' to 'double' changes value from 18446725308424768716 to 18446725308424769536 [-Wimplicit-const-int-float-conversion]
    double approx_double = 0xffffeeeeddddcccc * std::pow(2.0, 64.0) + 0xbbbbaaaa99998888;
                           ^~~~~~~~~~~~~~~~~~ ~
2 warnings generated.
Comment 1 Radar WebKit Bug Importer 2022-03-16 05:40:55 PDT 
<rdar://problem/90364907>
Comment 2 Basuke Suzuki 2022-03-16 10:26:54 PDT 
Created attachment 454854 [details]
PATCH
Comment 3 EWS 2022-03-16 13:51:40 PDT 
Committed r291363 (248495@main): <https://commits.webkit.org/248495@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454854 [details].