Bug 237891 – RemoteGraphicsContextGLProxy omits context lost checks for back and front buffer access functions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kimmo Kinnunen]

RemoteGraphicsContextGLProxy omits context lost checks for back and front buffer access functions

[Kimmo Kinnunen]

<rdar://90245766>

[Kimmo Kinnunen]

Created attachment 454704 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 454704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454704&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:142
> +        buffer.context().clearRect({ IntPoint(), buffer.backendSize() });

I’m a little confused. If the context is lost, how can you use the context to clearRect()?

[Kimmo Kinnunen]

Created attachment 454739 [details]
Patch

[Kimmo Kinnunen]

(In reply to Myles C. Maxfield from comment #3)
> 
> > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:142
> > +        buffer.context().clearRect({ IntPoint(), buffer.backendSize() });
> 
> I’m a little confused. If the context is lost, how can you use the context
> to clearRect()?

It's different context (graphics context of the image buffer, vs graphicscontextgl of webgl)
However, that's a good point -- if the context is lost, the GPU Process is unreliable and will be shut down, so the image buffer drawing does not make sense either. I'll remove this for now.

[EWS]

Committed r291314 (248453@main): <https://commits.webkit.org/248453@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454739 [details].