Bug 23789 - REGRESSION: Changing disabled state of a textarea does not do a repaint
Summary: REGRESSION: Changing disabled state of a textarea does not do a repaint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Julien Chaffraix
URL: http://dump.kkaefer.com/disabled.html
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 10:29 PST by Konstantin Käfer
Modified: 2011-12-08 16:59 PST (History)
5 users (show)

See Also:


Attachments
Proposed change: land a repaint test covering the existing test case. (2.73 KB, patch)
2011-12-08 14:21 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Käfer 2009-02-06 10:29:13 PST
In the most recent nightly build, changing the disabled state of a textarea does not do a repaint, thus, the textarea still appears as before even though the status has changed. As soon as the user (e.g.) resizes it, it's repainted and the status is reflected.

This worked in Safari 3.1.

This behavior seems to be broken on textareas. I tested this checkboxes and textfields (input type=text) and it seemed to work correctly for those, but not for textarea.
Comment 1 Konstantin Käfer 2009-02-06 10:30:06 PST
URL: http://dump.kkaefer.com/disabled.html

(This is not necessarily restricted to Mac OS X 10.5, but I can only confirm it for 10.5)
Comment 2 Konstantin Käfer 2009-02-06 10:32:01 PST
You might not see the effect when clicking on the link for the first time. After you reload the page, the bug should appear.
Comment 3 Eric Seidel (no email) 2009-02-06 10:33:29 PST
This seems to be a recent regression.  ToT fails his test case, but my unreleased Safari build from several months ago does not.
Comment 4 Julien Chaffraix 2011-12-08 10:30:32 PST
The bug does not reproduce on ToT (not sure when it was solved). I haven't found out a repaint test for this case so I will turn the original test case into one and land it.
Comment 5 Julien Chaffraix 2011-12-08 14:21:28 PST
Created attachment 118469 [details]
Proposed change: land a repaint test covering the existing test case.
Comment 6 Konstantin Käfer 2011-12-08 14:25:34 PST
I can confirm that the original bug I reported is fixed in current builds.
Comment 7 WebKit Review Bot 2011-12-08 16:59:04 PST
Comment on attachment 118469 [details]
Proposed change: land a repaint test covering the existing test case.

Clearing flags on attachment: 118469

Committed r102399: <http://trac.webkit.org/changeset/102399>
Comment 8 WebKit Review Bot 2011-12-08 16:59:08 PST
All reviewed patches have been landed.  Closing bug.