Bug 237881 – AX: imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html

is a constant text failure

[Radar WebKit Bug Importer]

<rdar://problem/90293806>

[chris fleizach]

Created attachment 454678 [details]
patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Created attachment 454678 [details]
> patch

--- a/Source/WebCore/ChangeLog
+++ a/Source/WebCore/ChangeLog

+        This test failure was being a previous speech job was canceled, and a new one started. 

This sentence sounds weird to me, perhaps "was being" -> "was due to" or "was happening when". But I'm not English grammar expert :-).

--- a/Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h
+++ a/Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h

+    id platformSpeechUtteranceWrapper() const { return m_platformSpeechUtteranceWrapper.get(); }
+    void setPlatformSpeechUtteranceWrapper(id utterance) { m_platformSpeechUtteranceWrapper = utterance; }

These names can be shortened to just wrapper() and setWrapper(...) like all other getters and setters in the class.

[chris fleizach]

Created attachment 454737 [details]
patch

[chris fleizach]

Created attachment 454770 [details]
patch

[EWS]

Committed r291344 (248483@main): <https://commits.webkit.org/248483@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454770 [details].