Bug 23788 – call style()->isOriginalDisplayInlineType() on RenderBox

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. Same as in RenderBlock::skipTrailingWhitespace(); 
The change in RenderBlock::skipTrailingWhitespace() was introduced by http://trac.webkit.org/changeset/40679 and probably was missed in RenderBlock::skipLeadingWhitespace().

[zalan]

Created attachment 27396 [details]
isOriginalDisplayInlineType() call

[Rob Buis]

Comment on attachment 27396 [details]
isOriginalDisplayInlineType() call

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 40718)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> [phone]  Zalan Bujtas  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +        
> +        https://bugs.webkit.org/show_bug.cgi?id=23788
> +        call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. 
> +        
> +        * rendering/bidi.cpp:
> +        (WebCore::RenderBlock::skipLeadingWhitespace):
> +
>  2009-02-06  Simon Hausmann  <[e-mail]>
>  
>          Reviewed by Tor Arne Vestbø.
> Index: WebCore/rendering/bidi.cpp
> ===================================================================
> --- WebCore/rendering/bidi.cpp	(revision 40717)
> +++ WebCore/rendering/bidi.cpp	(working copy)
> @@ -1480,7 +1480,7 @@ int RenderBlock::skipLeadingWhitespace(I
>      
>              RenderBox* box = toRenderBox(object);
>              if (box->style()->hasStaticX()) {
> -                if (object->style()->isOriginalDisplayInlineType())
> +                if (box->style()->isOriginalDisplayInlineType())
>                      box->layer()->setStaticX(style()->direction() == LTR ? leftOffset(height(), firstLine) : width() - rightOffset(height(), firstLine));
>                  else
>                      box->layer()->setStaticX(style()->direction() == LTR ? borderLeft() + paddingLeft() : borderRight() + paddingRight());

AFAICS the end result is the same, but indeed confusing to use object here. r = me

[Brent Fulgham]

Applied in http://trac.webkit.org/changeset/40766.