Bug 23788 - call style()->isOriginalDisplayInlineType() on RenderBox
Summary: call style()->isOriginalDisplayInlineType() on RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 06:34 PST by zalan
Modified: 2009-02-07 18:12 PST (History)
0 users

See Also:

Attachments
isOriginalDisplayInlineType() call (1.41 KB, patch)
2009-02-06 06:37 PST, zalan 		rwlbuis: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2009-02-06 06:34:52 PST 
call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. Same as in RenderBlock::skipTrailingWhitespace(); 
The change in RenderBlock::skipTrailingWhitespace() was introduced by http://trac.webkit.org/changeset/40679 and probably was missed in RenderBlock::skipLeadingWhitespace().
Comment 1 zalan 2009-02-06 06:37:31 PST 
Created attachment 27396 [details]
isOriginalDisplayInlineType() call
Comment 2 Rob Buis 2009-02-07 06:43:21 PST 
Comment on attachment 27396 [details]
isOriginalDisplayInlineType() call

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 40718)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2009-02-06  Zalan Bujtas  <zbujtas@gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +        
> +        https://bugs.webkit.org/show_bug.cgi?id=23788
> +        call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. 
> +        
> +        * rendering/bidi.cpp:
> +        (WebCore::RenderBlock::skipLeadingWhitespace):
> +
>  2009-02-06  Simon Hausmann  <simon.hausmann@nokia.com>
>  
>          Reviewed by Tor Arne Vestbø.
> Index: WebCore/rendering/bidi.cpp
> ===================================================================
> --- WebCore/rendering/bidi.cpp	(revision 40717)
> +++ WebCore/rendering/bidi.cpp	(working copy)
> @@ -1480,7 +1480,7 @@ int RenderBlock::skipLeadingWhitespace(I
>      
>              RenderBox* box = toRenderBox(object);
>              if (box->style()->hasStaticX()) {
> -                if (object->style()->isOriginalDisplayInlineType())
> +                if (box->style()->isOriginalDisplayInlineType())
>                      box->layer()->setStaticX(style()->direction() == LTR ? leftOffset(height(), firstLine) : width() - rightOffset(height(), firstLine));
>                  else
>                      box->layer()->setStaticX(style()->direction() == LTR ? borderLeft() + paddingLeft() : borderRight() + paddingRight());

AFAICS the end result is the same, but indeed confusing to use object here. r = me
Comment 3 Brent Fulgham 2009-02-07 18:12:21 PST 
Applied in http://trac.webkit.org/changeset/40766.