RESOLVED DUPLICATE of bug 237942 237875
[WebGPU] [NSString stringWithCString:encoding:] fails on a null pointer 
https://bugs.webkit.org/show_bug.cgi?id=237875
Summary [WebGPU] [NSString stringWithCString:encoding:] fails on a null pointer
Myles C. Maxfield
Reported 2022-03-14 21:55:33 PDT
.
Attachments
Patch (14.03 KB, patch)
2022-03-14 21:57 PDT, Myles C. Maxfield 		kkinnunen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-14 21:57:32 PDT
Created attachment 454661 [details] Patch
Kimmo Kinnunen
Comment 2 2022-03-15 08:37:31 PDT
Comment on attachment 454661 [details] Patch I think API type conversion should be done ASAP, e.g. a layer below. You wouldn't write "const char*" in WebKit level code, so why WebGPU level code. For me, overloaded ToAPI, FromAPI functions have been useful. In this case you would have String FromAPI(const char*) or NSString* FromAPI(const char*)
Kimmo Kinnunen
Comment 3 2022-03-15 08:39:00 PDT
and the code would be like void wgpuBindGroupSetLabel(WGPUBindGroup bindGroup, const char* label) { FromAPI(bindGroup)->setLabel(FromAPI(label)); }
Myles C. Maxfield
Comment 4 2022-03-15 22:32:29 PDT
*** This bug has been marked as a duplicate of bug 237942 ***
Myles C. Maxfield
Comment 5 2022-03-15 22:32:57 PDT
(In reply to Kimmo Kinnunen from comment #2) > Comment on attachment 454661 [details] > Patch > > I think API type conversion should be done ASAP, e.g. a layer below. You > wouldn't write "const char*" in WebKit level code, so why WebGPU level code. > For me, overloaded ToAPI, FromAPI functions have been useful. In this case > you would have String FromAPI(const char*) or NSString* FromAPI(const char*) https://bugs.webkit.org/show_bug.cgi?id=237942 [WebGPU] Use the fromAPI() pattern
Note You need to log in before you can comment on or make changes to this bug.