[WebGPU] [NSString stringWithCString:encoding:] fails on a null pointer

[Myles C. Maxfield]

.

[Myles C. Maxfield]

Created attachment 454661 [details]
Patch

[Kimmo Kinnunen]

Comment on attachment 454661 [details]
Patch

I think API type conversion should be done ASAP, e.g. a layer below. You wouldn't write "const char*" in WebKit level code, so why WebGPU level code.
For me, overloaded ToAPI, FromAPI functions have been useful. In this case you would have String FromAPI(const char*) or NSString* FromAPI(const char*)

[Kimmo Kinnunen]

and the code would be like

void wgpuBindGroupSetLabel(WGPUBindGroup bindGroup, const char* label)
{
    FromAPI(bindGroup)->setLabel(FromAPI(label));
}

[Myles C. Maxfield]

*** This bug has been marked as a duplicate of bug 237942 ***

[Myles C. Maxfield]

(In reply to Kimmo Kinnunen from comment #2)
> Comment on attachment 454661 [details]
> Patch
> 
> I think API type conversion should be done ASAP, e.g. a layer below. You
> wouldn't write "const char*" in WebKit level code, so why WebGPU level code.
> For me, overloaded ToAPI, FromAPI functions have been useful. In this case
> you would have String FromAPI(const char*) or NSString* FromAPI(const char*)

https://bugs.webkit.org/show_bug.cgi?id=237942 [WebGPU] Use the fromAPI() pattern