Bug 237868 - Serialize grid-template correctly
Summary: Serialize grid-template correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 204611
  Show dependency tree / graph
 
Reported: 2022-03-14 19:55 PDT by Matt Woodrow
Modified: 2022-03-27 20:04 PDT (History)
11 users (show)

See Also:

Attachments
Patch (30.69 KB, patch)
2022-03-14 20:06 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (32.78 KB, patch)
2022-03-15 13:38 PDT, Matt Woodrow 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (32.84 KB, patch)
2022-03-27 14:08 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-03-14 19:55:25 PDT 
grid-template has an option to take an interleaved set of lines names, track sizes and area names, and we're supposed to serialise the result back in the same format rather than listing areas at the end.
Comment 1 Radar WebKit Bug Importer 2022-03-14 19:55:46 PDT 
<rdar://problem/90284707>
Comment 2 Matt Woodrow 2022-03-14 20:06:47 PDT 
Created attachment 454654 [details]
Patch
Comment 3 Matt Woodrow 2022-03-15 13:38:22 PDT 
Created attachment 454752 [details]
Patch
Comment 4 Dean Jackson 2022-03-25 12:56:59 PDT 
Comment on attachment 454752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454752&action=review

> Source/WebCore/css/StyleProperties.cpp:835
> +    && downcast<CSSPrimitiveValue>(value.get())->valueID() == CSSValueNone;

Nit: We indent this line

> Source/WebCore/css/StyleProperties.cpp:837
> +}
> +static bool isValueID(const Ref<CSSValue>& value, CSSValueID id)

Nit: Need a blank line between these (and others)
Comment 5 Matt Woodrow 2022-03-27 14:08:28 PDT 
Created attachment 455867 [details]
Patch for landing
Comment 6 EWS 2022-03-27 20:04:47 PDT 
Committed r291955 (248922@main): <https://commits.webkit.org/248922@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455867 [details].