Bug 237856 - [WebAuthn] Mock UI interactions whenever virtual authenticators are in use.
Summary: [WebAuthn] Mock UI interactions whenever virtual authenticators are in use.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-14 16:02 PDT by pascoe@apple.com
Modified: 2022-03-15 16:25 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.68 KB, patch)
2022-03-14 19:39 PDT, pascoe@apple.com 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pascoe@apple.com 2022-03-14 16:02:30 PDT 
Which UI option to choose is unspecified. The convention is to select the first assertion / creation option.
Comment 1 Radar WebKit Bug Importer 2022-03-14 16:02:39 PDT 
<rdar://problem/90274854>
Comment 2 pascoe@apple.com 2022-03-14 19:39:55 PDT 
Created attachment 454652 [details]
Patch
Comment 3 Brent Fulgham 2022-03-15 16:14:19 PDT 
Comment on attachment 454652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454652&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:-100
> -    void decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&&) final;

It might be enough to just remove 'final' on these two methods, and not make them public.

> Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:43
> +    void runPanel();

void runPanel() override;

This can also be 'private', since it is an override of the parent class method.
Comment 4 EWS 2022-03-15 16:25:04 PDT 
Committed r291321 (248460@main): <https://commits.webkit.org/248460@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454652 [details].