Bug 237828 – [GStreamer] Avoid auto-selection of hole punching player

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Enrique Ocaña]

The hole punch player private shouldn't be automatically selected when the mime type is empty or unknown.

[Enrique Ocaña]

Created attachment 454588 [details]
Patch

[Enrique Ocaña]

Created attachment 454589 [details]
Patch

[Miguel Gomez]

Looks good to me Enrique!

[Enrique Ocaña]

The editing/spelling/spellcheck-api-crash.html failure in the iOS-15-Simulator-WK2-Tests-EWS bot is unrelated to this patch and should be ignored. Actually, I've been seeing that failure in some other unrelated EWS patch submissions these days.

[Xabier Rodríguez Calvar]

Comment on attachment 454589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review

> Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191
> +        if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType)))

!(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType)

[Carlos Garcia Campos]

Comment on attachment 454589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review

> Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:189
> +    if (m_player) {

Return early.

>> Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191
>> +        if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType)))
> 
> !(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType)

Extra parentheses after !

> Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h:79
> -    MediaPlayer::NetworkState networkState() const final { return MediaPlayer::NetworkState::Empty; };
> +    MediaPlayer::NetworkState networkState() const final;

We don't need to move this to the cpp, just return m_networkState here.

[Enrique Ocaña]

Created attachment 454729 [details]
Patch

[Enrique Ocaña]

Created attachment 454741 [details]
Patch

[EWS]

Committed r291337 (248476@main): <https://commits.webkit.org/248476@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454741 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90360852>