Bug 237827 – Keep service workers alive when they are inspected even though they should be terminated

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Keep service workers alive when they are inspected even though they should be terminated

[youenn fablet]

<rdar://88313935>

[youenn fablet]

Created attachment 454693 [details]
Patch

[youenn fablet]

Created attachment 454830 [details]
Patch

[youenn fablet]

Created attachment 454833 [details]
Patch

[youenn fablet]

Created attachment 454843 [details]
Patch

[youenn fablet]

Comment on attachment 454843 [details]
Patch

Error unrelated

[Alex Christensen]

Comment on attachment 454843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454843&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:548
> +    // We delay so that the push message will happen before the unregistration of the service worker client.
> +    sleep(0.5);

Wouldn't this be better to wait until pushMessageProcessed is true?

[youenn fablet]

(In reply to Alex Christensen from comment #7)
> Comment on attachment 454843 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454843&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:548
> > +    // We delay so that the push message will happen before the unregistration of the service worker client.
> > +    sleep(0.5);
> 
> Wouldn't this be better to wait until pushMessageProcessed is true?

The service worker is waiting to resolve the push message when there is no more clients, so we cannot wait here, we wait after we close the client.

[EWS]

Committed r291467 (248583@main): <https://commits.webkit.org/248583@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454843 [details].