Bug 237824 - [web-animations] marker-end should support discrete animation
Summary: [web-animations] marker-end should support discrete animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed, WPTImpact
Depends on:
Blocks:
 
Reported: 2022-03-14 03:32 PDT by Antoine Quint
Modified: 2022-03-14 06:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.09 KB, patch)
2022-03-14 03:36 PDT, Antoine Quint 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-03-14 03:32:40 PDT 
[web-animations] marker-end should support discrete animation
Comment 1 Antoine Quint 2022-03-14 03:36:12 PDT 
Created attachment 454569 [details]
Patch
Comment 2 Antti Koivisto 2022-03-14 05:56:22 PDT 
Comment on attachment 454569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454569&action=review

> LayoutTests/imported/w3c/ChangeLog:10
> +        Test failures are due to SVGURIReference::fragmentIdentifierFromIRIString() rejecting the values used in the
> +        test which do not contain a "#". While this is not the greatest test values for this property, this is indeed
> +        a bug that we reject the value during parsing instead of storing it.

Might be good to fix that too (separately) even though it is not exactly what you are focusing here on.
Comment 3 Antoine Quint 2022-03-14 06:50:03 PDT 
Committed r291226 (248381@trunk): <https://commits.webkit.org/248381@trunk>
Comment 4 Radar WebKit Bug Importer 2022-03-14 06:51:17 PDT 
<rdar://problem/90243904>