RESOLVED FIXED 237815
[macOS] Tooltip no longer disappears after leaving hovered element 
https://bugs.webkit.org/show_bug.cgi?id=237815
Summary [macOS] Tooltip no longer disappears after leaving hovered element
Wenson Hsieh
Reported 2022-03-12 21:00:46 PST
rdar://90187247
Attachments
Patch (5.89 KB, patch)
2022-03-12 21:43 PST, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Fix debug builds (7.29 KB, patch)
2022-03-12 22:23 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (11.50 KB, patch)
2022-03-14 16:18 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-03-12 21:43:54 PST
Created attachment 454547 [details] Patch
Wenson Hsieh
Comment 2 2022-03-12 22:23:59 PST
Created attachment 454550 [details] Fix debug builds
Alexey Proskuryakov
Comment 3 2022-03-14 13:46:06 PDT
Comment on attachment 454550 [details] Fix debug builds View in context: https://bugs.webkit.org/attachment.cgi?id=454550&action=review > Source/WebKit/ChangeLog:9 > + On certain versions of macOS, AppKit's tooltip management system installs tracking areas (NSTrackingArea) using Do we need to do anything in Legacy WebKit for this? I don't know much about NSTrackingAreas, but I know that there is code for those in WebHTMLView.mm.
Wenson Hsieh
Comment 4 2022-03-14 13:59:20 PDT
Comment on attachment 454550 [details] Fix debug builds (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 454550 [details] > Fix debug builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454550&action=review > > > Source/WebKit/ChangeLog:9 > > + On certain versions of macOS, AppKit's tooltip management system installs tracking areas (NSTrackingArea) using > > Do we need to do anything in Legacy WebKit for this? I don't know much about > NSTrackingAreas, but I know that there is code for those in WebHTMLView.mm. Good catch — confirmed that the same bug repros in WK1 as well. I suppose I'll fix both in this same patch.
Wenson Hsieh
Comment 5 2022-03-14 16:18:19 PDT
Created attachment 454634 [details] Patch
Wenson Hsieh
Comment 6 2022-03-15 06:47:59 PDT
Comment on attachment 454634 [details] Patch Thanks for the review!
EWS
Comment 7 2022-03-15 07:26:47 PDT
Committed r291287 (248426@main): <https://commits.webkit.org/248426@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454634 [details].
Note You need to log in before you can comment on or make changes to this bug.