Bug 237805 - Enhance StackCheck debugging support and bump up the ASAN reserved zone size.
Summary: Enhance StackCheck debugging support and bump up the ASAN reserved zone size.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-11 23:48 PST by Mark Lam
Modified: 2022-03-15 12:19 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (13.53 KB, patch)
2022-03-12 00:27 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-03-11 23:48:49 PST 
Patch coming.
Comment 1 Mark Lam 2022-03-12 00:27:31 PST 
Created attachment 454529 [details]
proposed patch.
Comment 2 Robin Morisset 2022-03-14 14:56:46 PDT 
Comment on attachment 454529 [details]
proposed patch.

r=me, looks nice
Comment 3 Mark Lam 2022-03-14 14:57:56 PDT 
Comment on attachment 454529 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 EWS 2022-03-14 15:41:10 PDT 
Committed r291255 (248407@main): <https://commits.webkit.org/248407@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454529 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-14 15:43:15 PDT 
<rdar://problem/90273699>
Comment 6 Philippe Normand 2022-03-15 11:39:09 PDT 
Comment on attachment 454529 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review

> Source/WTF/wtf/StackCheck.h:77
> +                reportVerificationFailureAndCrash();

Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?
Comment 7 Philippe Normand 2022-03-15 11:44:44 PDT 
I think this broke CMake debug builds, StackCheck.cpp is not listed in the CMakeLists.txt of WTF. I'll send a follow-up patch.
Comment 8 Philippe Normand 2022-03-15 11:48:03 PDT 
r291305
Comment 9 Mark Lam 2022-03-15 11:58:29 PDT 
Comment on attachment 454529 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review

>> Source/WTF/wtf/StackCheck.h:77
>> +                reportVerificationFailureAndCrash();
> 
> Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?

This entire block of code is under #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE already.
Comment 10 Philippe Normand 2022-03-15 12:19:02 PDT 
Comment on attachment 454529 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review

>>> Source/WTF/wtf/StackCheck.h:77
>>> +                reportVerificationFailureAndCrash();
>> 
>> Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?
> 
> This entire block of code is under #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE already.

Right, I should have expanded the diff scope. Sorry