Bug 237801 - AX: Move addChildren, addChild, insertChild, canHaveChildren, setNeedsToUpdateChildren, setNeedsToUpdateSubtree, clearChildren, and needsToUpdateChildren out of AXCoreObject interface
Summary: AX: Move addChildren, addChild, insertChild, canHaveChildren, setNeedsToUpdat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-11 16:56 PST by Tyler Wilcock
Modified: 2022-03-14 10:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.20 KB, patch)
2022-03-11 17:06 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2022-03-14 08:27 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-03-11 16:56:54 PST 
All of these methods are ASSERT_NOT_REACHED no-ops for AXIsolatedObjects, so we should move these virtual methods to AccessibilityObject instead.
Comment 1 Radar WebKit Bug Importer 2022-03-11 16:57:07 PST 
<rdar://problem/90188014>
Comment 2 Tyler Wilcock 2022-03-11 17:06:41 PST 
Created attachment 454524 [details]
Patch
Comment 3 Andres Gonzalez 2022-03-14 07:06:40 PDT 
(In reply to Tyler Wilcock from comment #2)
> Created attachment 454524 [details]
> Patch

--- a/Source/WebCore/accessibility/AccessibilityObject.h
+++ a/Source/WebCore/accessibility/AccessibilityObject.h

+    enum class DescendIfIgnored : uint8_t {
+        No,
+        Yes
+    };

Can we make this a one-liner? I.e.:

enum class DescendIfIgnored : uint8_t { No, Yes };
Comment 4 Tyler Wilcock 2022-03-14 08:27:01 PDT 
Created attachment 454592 [details]
Patch
Comment 5 EWS 2022-03-14 10:35:56 PDT 
Committed r291237 (248392@main): <https://commits.webkit.org/248392@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454592 [details].