Bug 237773 – [JSC] Use addressTempRegister in loadValue(void *) on 32 bits

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Angelos Oikonomopoulos]

[JSC] Use addressTempRegister in loadValue(void *) on 32 bits

[Angelos Oikonomopoulos]

Created attachment 454471 [details]
Patch

[Zan Dobersek (Reviews)]

Comment on attachment 454471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454471&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:76
> +    struct BoundsNonDoubleWordOffset {
> +        static bool within(intptr_t value)
> +        {
> +            return (value >= -0xff) && (value <= 0xfff);
> +        }
> +    };
> +    struct BoundsDoubleWordOffset {
> +        static bool within(intptr_t value)
> +        {
> +            if (value < 0)
> +                value = -value;
> +            return !(value & ~0x3fc);
> +        }
> +    };

We could argue about these types' names, but let's not.

[Angelos Oikonomopoulos]

Created attachment 454554 [details]
Patch

[Angelos Oikonomopoulos]

(In reply to Zan Dobersek (Reviews) from comment #2)
[...]
> We could argue about these types' names, but let's not.

No argument from me.

[EWS]

Committed r291217 (248372@main): <https://commits.webkit.org/248372@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454554 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90216258>