RESOLVED FIXED 23777
Make WorkerMessagingProxy class derive from two base proxy classes. 
https://bugs.webkit.org/show_bug.cgi?id=23777
Summary Make WorkerMessagingProxy class derive from two base proxy classes.
Jian Li
Reported 2009-02-05 18:46:38 PST
After two base proxy classes are added, we need to make WorkerMessagingProxy class derive from these two base classes.
Attachments
Proposed Patch (9.49 KB, patch)
2009-02-05 19:00 PST, Jian Li 		no flags
DetailsFormatted DiffDiff
Proposed Patch (9.45 KB, patch)
2009-02-06 13:24 PST, Jian Li 		no flags
DetailsFormatted DiffDiff
Proposed Patch (9.46 KB, patch)
2009-02-06 17:46 PST, Jian Li 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-02-05 19:00:03 PST
Created attachment 27375 [details] Proposed Patch This patch is to make WorkerMessagingProxy derive from two base proxy classes introduced in issue 23776. The next patch is to change to use different proxy pointers.
David Levin
Comment 2 2009-02-06 02:35:09 PST
ChangeLog: WorkerMessaingProxy sp These header files seem to be missing from the patch: #include "WorkerContextProxyBase.h" #include "WorkerObjectProxyBase.h"
David Levin
Comment 3 2009-02-06 02:41:14 PST
I see that have the header files in another patch. I'd recommend setting the "depends on" field above to make this more clear.
David Levin
Comment 4 2009-02-06 03:01:23 PST
This looks good to me (just needs the typo fixed in the change log).
Jian Li
Comment 5 2009-02-06 13:24:20 PST
Created attachment 27415 [details] Proposed Patch
David Levin
Comment 6 2009-02-06 13:25:16 PST
Comment on attachment 27375 [details] Proposed Patch new patch obsoletes previous one.
David Levin
Comment 7 2009-02-06 15:18:22 PST
It would be nice to fix the typo: ChangeLog: WorkerMessaingProxy sp
Jian Li
Comment 8 2009-02-06 17:46:05 PST
Created attachment 27442 [details] Proposed Patch All fixed. Thanks.
David Levin
Comment 9 2009-02-07 23:03:25 PST
Comment on attachment 27415 [details] Proposed Patch New patch makes this one obsolete.
David Levin
Comment 10 2009-02-07 23:09:11 PST
Looks good to me.
Alexey Proskuryakov
Comment 11 2009-02-09 02:09:37 PST
Comment on attachment 27442 [details] Proposed Patch r=me. I think that to validate this change, you need to also change the type of Worker::m_messagingProxy though. // Only use these methods on the worker object thread. - void terminate(); bool askedToTerminate() const { return m_askedToTerminate; } There's only one method left here, so the comment needs to be adjusted.
Alexey Proskuryakov
Comment 12 2009-02-09 02:14:14 PST
Committed revision 40781.
Note You need to log in before you can comment on or make changes to this bug.