Bug 237751 - Unreviewed, non-unified build fix after 248294@main
Summary: Unreviewed, non-unified build fix after 248294@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-10 18:14 PST by Lauro Moura
Modified: 2022-03-10 19:24 PST (History)
2 users (show)

See Also:

Attachments
[fast-cq] Patch (1.23 KB, patch)
2022-03-10 18:15 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2022-03-10 18:14:19 PST 
Unreviewed, non-unified build fix after 248294@main
Comment 1 Lauro Moura 2022-03-10 18:15:25 PST 
Created attachment 454435 [details]
[fast-cq] Patch
Comment 2 Lauro Moura 2022-03-10 18:16:25 PST 
/app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp: In member function ‘void WebCore::LayoutIntegration::LineLayout::updateListItemDimensions(const WebCore::RenderListItem&)’:  
/app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:160:31: error: cannot convert ‘const WebCore::RenderListItem’ to ‘const WebCore::RenderBox&’                                  
  160 |     updateLayoutBoxDimensions(listItem);                                                                                                                                                            
      |                               ^~~~~~~~                                                                                                                                                              
      |                               |                                                                                                                                                                     
      |                               const WebCore::RenderListItem                                                                                                                                         
In file included from /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:27:                                                                                                     
/app/webkit/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.h:135:36: note:   initializing argument 1 of ‘void WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions(const WebCore
::RenderBox&)’                                                                                                                                                                                              
  135 |     void updateLayoutBoxDimensions(const RenderBox&);                                                                                                                                               
      |                                    ^~~~~~~~~~~~~~~~
Comment 3 zalan 2022-03-10 18:50:37 PST 
Sorry about that (and thank you for fixing it).
Comment 4 EWS 2022-03-10 19:23:14 PST 
Committed r291143 (248303@main): <https://commits.webkit.org/248303@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454435 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-10 19:24:15 PST 
<rdar://problem/90138290>