Bug 237745 - Web Inspector: REGRESSION(r287753): Settings: checkboxes are smaller and no longer vertically align with related text
Summary: Web Inspector: REGRESSION(r287753): Settings: checkboxes are smaller and no l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 234897
Blocks:
  Show dependency treegraph
 
Reported: 2022-03-10 16:24 PST by Devin Rousso
Modified: 2022-03-17 21:24 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2022-03-17 15:16 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (55.25 KB, image/png)
2022-03-17 15:17 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-03-10 16:24:06 PST
compare ToT with the screenshots on <https://webkit.org/web-inspector/web-inspector-settings/>
Comment 1 Radar WebKit Bug Importer 2022-03-10 16:24:30 PST
<rdar://problem/90129658>
Comment 2 Devin Rousso 2022-03-10 16:26:18 PST
@Aditya Keerthi tells me that it's expected behavior for `font-size` to NOT adjust the sizing of `<input type="checkbox">`, so the following code in `Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css` is no longer valid:
```css
.content-view.tab.settings > .settings-view > .container > .editor-group > .setting-editor input[type="checkbox"] {
    /* Vertically align <select> with the group title text. */
    font-size: 16px;
}
```
Comment 3 Nikita Vasilyev 2022-03-17 15:16:50 PDT
Created attachment 455035 [details]
Patch
Comment 4 Nikita Vasilyev 2022-03-17 15:17:19 PDT
Created attachment 455036 [details]
[Image] With patch applied
Comment 5 Devin Rousso 2022-03-17 20:37:44 PDT
Comment on attachment 455035 [details]
Patch

rs=me
Comment 6 EWS 2022-03-17 21:24:34 PDT
Committed r291466 (248582@main): <https://commits.webkit.org/248582@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455035 [details].