Bug 237736 – [WGSL] Add the core parts of the behavior checker

• Status: ASSIGNED
• Component: WebGPU

[Robin Morisset]

There are a few validation phases required for WGSL:
- Type checking
- Behavior checking (see https://www.w3.org/TR/WGSL/#behaviors)
- Uniformity analysis
- no recursion
- only valid attributes applied
- etc...

I decided to start by the behavior checking, for the following reasons:
- It is fairly simple
- But it touches both statements and expressions
- And it will be required for uniformity

[Robin Morisset]

Created attachment 454430 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 454430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454430&action=review

> Source/WTF/ChangeLog:9
> +        Added IndexMap::insert, which automatically grows the underlying vector if needed.
> +        It allows using IndexMap ergonomically even if we don't know the number of keys ahead of time.

This probably should be its own patch, with its own TestWTF tests

[Robin Morisset]

(In reply to Myles C. Maxfield from comment #2)
> Comment on attachment 454430 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454430&action=review
> 
> > Source/WTF/ChangeLog:9
> > +        Added IndexMap::insert, which automatically grows the underlying vector if needed.
> > +        It allows using IndexMap ergonomically even if we don't know the number of keys ahead of time.
> 
> This probably should be its own patch, with its own TestWTF tests

IndexMap currently does not seem to have any test whatsoever. I filed https://bugs.webkit.org/show_bug.cgi?id=237847 about it.

[Robin Morisset]

Created attachment 454617 [details]
Patch

Validator.h was missing.

[Robin Morisset]

Comment on attachment 454617 [details]
Patch

Cancelling the review as trying to implement the uniformity analysis in the same style showed that it is too limited.

[Radar WebKit Bug Importer]

<rdar://problem/90458338>

[Robin Morisset]

Created attachment 457573 [details]
WIP