RESOLVED FIXED 237734
Abandoned memory in NetworkStorageManager::m_temporaryBlobPathsByConnection 
https://bugs.webkit.org/show_bug.cgi?id=237734
Summary Abandoned memory in NetworkStorageManager::m_temporaryBlobPathsByConnection
Sihui Liu
Reported 2022-03-10 14:45:05 PST
...
Attachments
Patch (1.64 KB, patch)
2022-03-10 14:47 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-03-10 14:47:43 PST
Created attachment 454404 [details] Patch
Chris Dumez
Comment 2 2022-03-10 14:50:58 PST
Comment on attachment 454404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454404&action=review > Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:214 > + protectedThis->m_temporaryBlobPathsByConnection.remove(connection); Can't we do this before the work queue dispatch(), instead of re-dispatching to the main thread here?
Sihui Liu
Comment 3 2022-03-10 14:53:50 PST
(In reply to Chris Dumez from comment #2) > Comment on attachment 454404 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454404&action=review > > > Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:214 > > + protectedThis->m_temporaryBlobPathsByConnection.remove(connection); > > Can't we do this before the work queue dispatch(), instead of re-dispatching > to the main thread here? This technically should be removed after we notify storage thread; and we need to dispatch to the main thread to deter NetworkStorageManager anyways
EWS
Comment 4 2022-03-10 21:41:00 PST
Committed r291145 (248305@main): <https://commits.webkit.org/248305@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454404 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-10 21:42:16 PST
<rdar://problem/90142912>
Note You need to log in before you can comment on or make changes to this bug.