Bug 237720 - [selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be called in setRangeText
Summary: [selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be call...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zsun
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-10 09:21 PST by zsun
Modified: 2022-07-19 21:05 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.66 KB, patch)
2022-03-10 09:32 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (12.65 KB, patch)
2022-03-15 02:50 PDT, zsun 		no flags Details | Formatted Diff | Diff
Patch (9.35 KB, patch)
2022-03-17 03:42 PDT, zsun 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zsun 2022-03-10 09:21:58 PST 
Affected WPT tests:
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html
Comment 1 zsun 2022-03-10 09:32:33 PST 
Created attachment 454372 [details]
Patch
Comment 2 Chris Dumez 2022-03-14 16:29:37 PDT 
Comment on attachment 454372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454372&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        We shouldn't call HTMLTextFormControlElement::subtreeHasChanged()  in HTMLTextFormControlElement::setRangeText.

nit: extra space before "in"

> Source/WebCore/ChangeLog:11
> +        This cl refers and imports some of the changes in chromiu CL at

I think "cl" is a chrome/blink term.

Also typo: chromiu
Comment 3 zsun 2022-03-15 02:50:00 PDT 
Created attachment 454684 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2022-03-16 05:41:31 PDT 
<rdar://problem/90364922>
Comment 5 zsun 2022-03-17 03:42:17 PDT 
Created attachment 454953 [details]
Patch
Comment 6 zsun 2022-03-21 01:55:47 PDT 
Landing this patch. The test failure in ios-wk2 doesn't seem related to this patch.
Comment 7 EWS 2022-03-21 02:28:16 PDT 
Committed r291555 (248659@main): <https://commits.webkit.org/248659@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454953 [details].