Bug 237704 – Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource

[youenn fablet]

Created attachment 454333 [details]
WIP

[Radar WebKit Bug Importer]

<rdar://problem/90424679>

[youenn fablet]

Created attachment 455904 [details]
Patch

[Eric Carlson]

Comment on attachment 455904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455904&action=review

> Source/WebCore/ChangeLog:9
> +        The remove video source is now correctly exposing whether it is camera, screen...

s/remove/remote/

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:81
> +        fprintf(stderr, "RemoteRealtimeMediaSource::createRemoteMediaSource %p %d \n", this, (int) settings.width());

Don't forget to remove this

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:107
> +    fprintf(stderr, "RemoteRealtimeMediaSource::setSettings1 %p %d \n", this, (int) m_settings.width());

Ditto

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:110
> +    fprintf(stderr, "RemoteRealtimeMediaSource::setSettings2 %p %d \n", this, (int) m_settings.width());

Ditto

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:120
> +void RemoteRealtimeMediaSource::hasEnded()

We should change this name, `hasEnded` sounds like it is a getter. Maybe `didEnd` would be better?

[youenn fablet]

Created attachment 455916 [details]
Patch

[EWS]

Committed r291967 (248932@main): <https://commits.webkit.org/248932@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455916 [details].