Bug 237701 - Unify reference box / CTM computation in RenderLayer
Summary: Unify reference box / CTM computation in RenderLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on: 237553 237554
Blocks: 90738 211787 237711
  Show dependency tree / graph
 
Reported: 2022-03-10 01:32 PST by Nikolas Zimmermann
Modified: 2022-04-07 15:56 PDT (History)
18 users (show)

See Also:

Attachments
Patch, v1 (18.92 KB, patch)
2022-03-10 01:34 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v2 (18.92 KB, patch)
2022-03-10 05:56 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v3 (18.88 KB, patch)
2022-03-10 06:17 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v4 (21.33 KB, patch)
2022-03-10 15:37 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v5 (20.04 KB, patch)
2022-03-13 16:46 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v6 (20.03 KB, patch)
2022-03-16 03:25 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v7 (19.46 KB, patch)
2022-03-21 02:50 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v8 (19.46 KB, patch)
2022-04-04 13:34 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v9 (19.95 KB, patch)
2022-04-05 14:58 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v10 (19.98 KB, patch)
2022-04-07 03:24 PDT, Nikolas Zimmermann 		rbuis: review+
Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-03-10 01:32:05 PST 
Currently RenderLayer::updateTransform() and RenderLayer::currentTransform() contain code to compute the CTM, apply pixel snapping, etc.
Unify them into a single updateTransformFromStyle() helper method, that can be used later by LBSE to e.g. disable pixel snapping for the SVG subtree in one place, instead of sprinkling LBSE code over multiple places.
Comment 1 Nikolas Zimmermann 2022-03-10 01:34:23 PST 
Created attachment 454324 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2022-03-10 05:56:51 PST 
Created attachment 454349 [details]
Patch, v2
Comment 3 Nikolas Zimmermann 2022-03-10 06:17:41 PST 
Created attachment 454355 [details]
Patch, v3
Comment 4 Nikolas Zimmermann 2022-03-10 15:37:42 PST 
Created attachment 454410 [details]
Patch, v4
Comment 5 Nikolas Zimmermann 2022-03-13 16:46:45 PDT 
Created attachment 454561 [details]
Patch, v5
Comment 6 Nikolas Zimmermann 2022-03-16 03:25:30 PDT 
Created attachment 454816 [details]
Patch, v6
Comment 7 Radar WebKit Bug Importer 2022-03-16 05:39:59 PDT 
<rdar://problem/90364879>
Comment 8 Nikolas Zimmermann 2022-03-21 02:50:39 PDT 
Created attachment 455225 [details]
Patch, v7
Comment 9 Nikolas Zimmermann 2022-04-04 13:34:46 PDT 
Created attachment 456617 [details]
Patch, v8
Comment 10 Nikolas Zimmermann 2022-04-05 14:58:45 PDT 
Created attachment 456752 [details]
Patch, v9
Comment 11 Nikolas Zimmermann 2022-04-07 03:24:05 PDT 
Created attachment 456901 [details]
Patch, v10
Comment 12 Rob Buis 2022-04-07 06:18:47 PDT 
Comment on attachment 456901 [details]
Patch, v10

View in context: https://bugs.webkit.org/attachment.cgi?id=456901&action=review

> Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h:50
> +

Empty line maybe not needed.
Comment 13 Nikolas Zimmermann 2022-04-07 15:56:42 PDT 
Committed r292575 (?): <https://commits.webkit.org/r292575>