Bug 237698 – Fix WebContent jetsam that occurs when selecting text in a large e-mail

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Ben Nham]

WebContent often jetsams when selecting text in a large e-mail in MobileMail.

[Ben Nham]

rdar://88549631

[Ben Nham]

Created attachment 454314 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 454314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454314&action=review

> Source/WebCore/page/FrameView.cpp:2735
> +#if PLATFORM(IOS_FAMILY)
> +        tiledBacking->prepopulateRect(FloatRect(position, exposedContentRect().size()));
> +#else
> +        auto rect = FloatRect(position, visibleContentRect().size());
> +        if (auto exposedRect = viewExposedRect()) {
> +            exposedRect->setLocation(position);
> +            rect.intersect(*exposedRect);
> +        }
> +        tiledBacking->prepopulateRect(rect);
> +#endif

I generally prefer the #ifdef to just surround the argument computation, so there's only one line that calls tiledBacking->prepopulateRect().

Are you sure you want to change the macOS behavior at this time?

[Ben Nham]

It's probably better to leave the macOS path alone since content rects work differently on that platform and we don't have evidence of this bug on macOS.

I'll submit a newer version of the patch.

[Ben Nham]

Created attachment 454315 [details]
Patch

[EWS]

Committed r291175 (248335@main): <https://commits.webkit.org/248335@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454315 [details].