Bug 23769 - Use non-null ResourceError errors.
Summary: Use non-null ResourceError errors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-05 12:57 PST by Xan Lopez
Modified: 2009-02-06 02:10 PST (History)
0 users

See Also:

Attachments
nonnull-errors.patch (3.87 KB, patch)
2009-02-05 12:59 PST, Xan Lopez 		no flags Details | Formatted Diff | Diff
nonnull-errorsv2.patch (3.93 KB, patch)
2009-02-05 14:24 PST, Xan Lopez 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-02-05 12:57:43 PST 
Rather create bogus but non-null errors, since some codepaths expect these. For example, see DocumentLoader::mainReceivedError.
Comment 1 Xan Lopez 2009-02-05 12:59:09 PST 
Created attachment 27359 [details]
nonnull-errors.patch
Comment 2 Alexey Proskuryakov 2009-02-05 14:17:37 PST 
Comment on attachment 27359 [details]
nonnull-errors.patch

I think it would be nice and easy to make cancelledError return a cancellation - like it is done in emptyClients.
Comment 3 Xan Lopez 2009-02-05 14:24:04 PST 
Created attachment 27363 [details]
nonnull-errorsv2.patch
Comment 4 Alexey Proskuryakov 2009-02-06 02:08:54 PST 
Comment on attachment 27363 [details]
nonnull-errorsv2.patch

r=me
Comment 5 Alexey Proskuryakov 2009-02-06 02:10:32 PST 
Committed revision 40716.