Bug 237681 - [Flatpak SDK] Include gi-docgen and its dependencies
Summary: [Flatpak SDK] Include gi-docgen and its dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: 226662
  Show dependency tree / graph
 
Reported: 2022-03-09 15:10 PST by Adrian Perez
Modified: 2022-03-20 04:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2022-03-18 09:30 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch (3.95 KB, patch)
2022-03-19 16:11 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-03-09 15:10:14 PST 
As part of the work for bug #226662 we will want to have gi-docgen
in the SDK, to make developer builds check whether documentation is
complete :]
Comment 1 Adrian Perez 2022-03-18 09:30:04 PDT 
Created attachment 455100 [details]
Patch
Comment 2 Adrian Perez 2022-03-19 14:22:39 PDT 
Comment on attachment 455100 [details]
Patch

Setting cq-, after building the SDK locally and giving it a go, it turns
out that gi-docgen also uses python-smartypants — gotta add that one, too!
Comment 3 Adrian Perez 2022-03-19 16:11:52 PDT 
Created attachment 455181 [details]
Patch

Now with the (previously missing) smartypants Python package.
Comment 4 EWS 2022-03-20 04:47:30 PDT 
Committed r291542 (248648@main): <https://commits.webkit.org/248648@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455181 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-20 04:48:16 PDT 
<rdar://problem/90536925>