Bug 23767 - Add custom V8 bindings for HTML5 database
Summary: Add custom V8 bindings for HTML5 database
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-05 12:51 PST by Dimitri Glazkov (Google)
Modified: 2009-02-05 15:12 PST (History)
0 users

See Also:

Attachments
Add custom V8 bindings for HTML5 database, v1 (44.75 KB, patch)
2009-02-05 12:55 PST, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-05 12:51:00 PST 
These are the first V8 bindings going into the trunk.
Comment 1 Dimitri Glazkov (Google) 2009-02-05 12:55:37 PST 
Created attachment 27358 [details]
Add custom V8 bindings for HTML5 database, v1

 WebCore/ChangeLog                                  |   45 ++++++++
 .../v8/custom/V8CustomSQLStatementCallback.cpp     |   72 ++++++++++++
 .../v8/custom/V8CustomSQLStatementCallback.h       |   62 +++++++++++
 .../custom/V8CustomSQLStatementErrorCallback.cpp   |   76 +++++++++++++
 .../v8/custom/V8CustomSQLStatementErrorCallback.h  |   64 +++++++++++
 .../v8/custom/V8CustomSQLTransactionCallback.cpp   |   75 +++++++++++++
 .../v8/custom/V8CustomSQLTransactionCallback.h     |   62 +++++++++++
 .../custom/V8CustomSQLTransactionErrorCallback.cpp |   75 +++++++++++++
 .../custom/V8CustomSQLTransactionErrorCallback.h   |   63 +++++++++++
 .../bindings/v8/custom/V8CustomVoidCallback.cpp    |   97 +++++++++++++++++
 WebCore/bindings/v8/custom/V8CustomVoidCallback.h  |   66 +++++++++++
 WebCore/bindings/v8/custom/V8DatabaseCustom.cpp    |   93 ++++++++++++++++
 .../v8/custom/V8SQLResultSetRowListCustom.cpp      |   90 +++++++++++++++
 .../bindings/v8/custom/V8SQLTransactionCustom.cpp  |  114 ++++++++++++++++++++
 14 files changed, 1054 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-05 14:24:07 PST 
Comment on attachment 27358 [details]
Add custom V8 bindings for HTML5 database, v1

Looks sane to me.  I can't claim to be an expert in V8 or the Database spec, but this code looks clean, and un-harmful.  I was surprised to separate objects for each callback type.  I wonder if there is yet more code sharing which could be done there.
Comment 3 Dimitri Glazkov (Google) 2009-02-05 15:12:48 PST 
Landed as http://trac.webkit.org/changeset/40687.