Bug 23767 – Add custom V8 bindings for HTML5 database

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Dimitri Glazkov (Google)]

These are the first V8 bindings going into the trunk.

[Dimitri Glazkov (Google)]

Created attachment 27358 [details]
Add custom V8 bindings for HTML5 database, v1

 WebCore/ChangeLog                                  |   45 ++++++++
 .../v8/custom/V8CustomSQLStatementCallback.cpp     |   72 ++++++++++++
 .../v8/custom/V8CustomSQLStatementCallback.h       |   62 +++++++++++
 .../custom/V8CustomSQLStatementErrorCallback.cpp   |   76 +++++++++++++
 .../v8/custom/V8CustomSQLStatementErrorCallback.h  |   64 +++++++++++
 .../v8/custom/V8CustomSQLTransactionCallback.cpp   |   75 +++++++++++++
 .../v8/custom/V8CustomSQLTransactionCallback.h     |   62 +++++++++++
 .../custom/V8CustomSQLTransactionErrorCallback.cpp |   75 +++++++++++++
 .../custom/V8CustomSQLTransactionErrorCallback.h   |   63 +++++++++++
 .../bindings/v8/custom/V8CustomVoidCallback.cpp    |   97 +++++++++++++++++
 WebCore/bindings/v8/custom/V8CustomVoidCallback.h  |   66 +++++++++++
 WebCore/bindings/v8/custom/V8DatabaseCustom.cpp    |   93 ++++++++++++++++
 .../v8/custom/V8SQLResultSetRowListCustom.cpp      |   90 +++++++++++++++
 .../bindings/v8/custom/V8SQLTransactionCustom.cpp  |  114 ++++++++++++++++++++
 14 files changed, 1054 insertions(+), 0 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 27358 [details]
Add custom V8 bindings for HTML5 database, v1

Looks sane to me.  I can't claim to be an expert in V8 or the Database spec, but this code looks clean, and un-harmful.  I was surprised to separate objects for each callback type.  I wonder if there is yet more code sharing which could be done there.

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/40687.