Bug 237668 - [CMake] Associate platform specific configuration with WinCairo
Summary: [CMake] Associate platform specific configuration with WinCairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-09 10:21 PST by Don Olmstead
Modified: 2022-03-09 12:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2022-03-09 10:33 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-03-09 10:21:07 PST 
Some is in the root source listing some is under WinCairo check. Just make it all under WinCairo.
Comment 1 Don Olmstead 2022-03-09 10:33:12 PST 
Created attachment 454266 [details]
Patch
Comment 2 Basuke Suzuki 2022-03-09 10:36:59 PST 
Comment on attachment 454266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

> Source/WebKit/PlatformWin.cmake:-170
> -

Is it okay to remove these definitions?
Comment 3 Don Olmstead 2022-03-09 10:38:21 PST 
Comment on attachment 454266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

>> Source/WebKit/PlatformWin.cmake:-170
>> -
> 
> Is it okay to remove these definitions?

Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways.
Comment 4 Basuke Suzuki 2022-03-09 10:39:14 PST 
Comment on attachment 454266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

>>> Source/WebKit/PlatformWin.cmake:-170
>>> -
>> 
>> Is it okay to remove these definitions?
> 
> Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways.

Great.
Comment 5 EWS 2022-03-09 12:45:50 PST 
Committed r291061 (248234@main): <https://commits.webkit.org/248234@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454266 [details].