RESOLVED FIXED 237668
[CMake] Associate platform specific configuration with WinCairo 
https://bugs.webkit.org/show_bug.cgi?id=237668
Summary [CMake] Associate platform specific configuration with WinCairo
Don Olmstead
Reported 2022-03-09 10:21:07 PST
Some is in the root source listing some is under WinCairo check. Just make it all under WinCairo.
Attachments
Patch (3.70 KB, patch)
2022-03-09 10:33 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-03-09 10:33:12 PST
Created attachment 454266 [details] Patch
Basuke Suzuki
Comment 2 2022-03-09 10:36:59 PST
Comment on attachment 454266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review > Source/WebKit/PlatformWin.cmake:-170 > - Is it okay to remove these definitions?
Don Olmstead
Comment 3 2022-03-09 10:38:21 PST
Comment on attachment 454266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review >> Source/WebKit/PlatformWin.cmake:-170 >> - > > Is it okay to remove these definitions? Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways.
Basuke Suzuki
Comment 4 2022-03-09 10:39:14 PST
Comment on attachment 454266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review >>> Source/WebKit/PlatformWin.cmake:-170 >>> - >> >> Is it okay to remove these definitions? > > Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways. Great.
EWS
Comment 5 2022-03-09 12:45:50 PST
Committed r291061 (248234@main): <https://commits.webkit.org/248234@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454266 [details].
Note You need to log in before you can comment on or make changes to this bug.