Bug 237661 - [web-animations] font-variant-alternates should support discrete animation
Summary: [web-animations] font-variant-alternates should support discrete animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed, WPTImpact
Depends on:
Blocks:
 
Reported: 2022-03-09 09:40 PST by Antoine Quint
Modified: 2022-03-10 04:51 PST (History)
12 users (show)

See Also:

Attachments
Patch (12.21 KB, patch)
2022-03-09 09:42 PST, Antoine Quint 		mmaxfield: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-03-09 09:40:38 PST 
[web-animations] font-variant-alternates should support discrete animation
Comment 1 Antoine Quint 2022-03-09 09:42:00 PST 
Created attachment 454251 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-03-09 11:29:36 PST 
Comment on attachment 454251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review

> Source/WebCore/rendering/style/RenderStyle.h:376
> +    FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); }

Do we need to fix RenderStyle::diff() for this?
Comment 3 Myles C. Maxfield 2022-03-09 16:51:39 PST 
Comment on attachment 454251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review

>> Source/WebCore/rendering/style/RenderStyle.h:376
>> +    FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); }
> 
> Do we need to fix RenderStyle::diff() for this?

No. It's handled by FontDescription::operator==().
Comment 4 Antoine Quint 2022-03-10 04:50:15 PST 
Committed r291104 (248266@trunk): <https://commits.webkit.org/248266@trunk>
Comment 5 Radar WebKit Bug Importer 2022-03-10 04:51:16 PST 
<rdar://problem/90091977>