Bug 237651 - [web-animations] increase the max number of animatable properties
Summary: [web-animations] increase the max number of animatable properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-09 05:27 PST by Antoine Quint
Modified: 2022-03-09 05:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2022-03-09 05:28 PST, Antoine Quint 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-03-09 05:27:20 PST 
[web-animations] increase the max number of animatable properties
Comment 1 Antoine Quint 2022-03-09 05:28:09 PST 
Created attachment 454230 [details]
Patch
Comment 2 Antti Koivisto 2022-03-09 05:29:57 PST 
Comment on attachment 454230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454230&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:2896
> +    COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax);

more modern C++ would say std::numeric_limits<unsigned short>::max()
Comment 3 Antoine Quint 2022-03-09 05:44:34 PST 
Committed r291047 (248221@trunk): <https://commits.webkit.org/248221@trunk>
Comment 4 Antoine Quint 2022-03-09 05:45:10 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 454230 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454230&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:2896
> > +    COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax);
> 
> more modern C++ would say std::numeric_limits<unsigned short>::max()

Used that in the commit. Thank you!
Comment 5 Radar WebKit Bug Importer 2022-03-09 05:45:17 PST 
<rdar://problem/90026878>