Bug 237650 - [web-animations] font-synthesis should support discrete animation
Summary: [web-animations] font-synthesis should support discrete animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed, WPTImpact
Depends on:
Blocks:
 
Reported: 2022-03-09 04:30 PST by Antoine Quint
Modified: 2022-03-10 04:46 PST (History)
11 users (show)

See Also:

Attachments
Patch (9.45 KB, patch)
2022-03-09 04:30 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (9.61 KB, patch)
2022-03-09 11:17 PST, Antoine Quint 		mmaxfield: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-03-09 04:30:37 PST 
[web-animations] font-synthesis should support discrete animation
Comment 1 Antoine Quint 2022-03-09 04:30:58 PST 
Created attachment 454228 [details]
Patch
Comment 2 Antoine Quint 2022-03-09 11:17:46 PST 
Created attachment 454271 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-03-09 11:29:02 PST 
Comment on attachment 454271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review

> Source/WebCore/rendering/style/RenderStyle.h:376
> +    FontSynthesis fontSynthesis() const { return fontDescription().fontSynthesis(); }

Do we need to fix RenderStyle::diff() for this too?
Comment 4 Myles C. Maxfield 2022-03-09 16:50:42 PST 
Comment on attachment 454271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review

>> Source/WebCore/rendering/style/RenderStyle.h:376
>> +    FontSynthesis fontSynthesis() const { return fontDescription().fontSynthesis(); }
> 
> Do we need to fix RenderStyle::diff() for this too?

No. This is handled by FontDescription::operator==().
Comment 5 Antoine Quint 2022-03-10 04:45:07 PST 
Committed r291103 (248265@trunk): <https://commits.webkit.org/248265@trunk>
Comment 6 Radar WebKit Bug Importer 2022-03-10 04:46:17 PST 
<rdar://problem/90091827>