Bug 23765 - Return correct computed style during accelerated animations
Summary: Return correct computed style during accelerated animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 23359
  Show dependency treegraph
 
Reported: 2009-02-05 11:46 PST by Simon Fraser (smfr)
Modified: 2009-02-05 15:09 PST (History)
1 user (show)

See Also:


Attachments
Patch, changelog (16.55 KB, patch)
2009-02-05 13:54 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Revised patch (21.21 KB, patch)
2009-02-05 15:02 PST, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-02-05 11:46:20 PST
If you request the value of opacity or transform while they are being acceler-animated, we need to return the correct value.
Comment 1 Simon Fraser (smfr) 2009-02-05 13:54:11 PST
Created attachment 27362 [details]
Patch, changelog
Comment 2 Dave Hyatt 2009-02-05 14:01:00 PST
Comment on attachment 27362 [details]
Patch, changelog

return renderer && renderer->hasLayer() && toRenderBox(renderer)->layer()->isComposited();

RenderLayer now owns a RenderBoxModelObject and not a RenderBox.  Once RenderInline moves to RenderBox, converting to RenderBox won't be correct
Comment 3 Simon Fraser (smfr) 2009-02-05 15:02:57 PST
Created attachment 27366 [details]
Revised patch
Comment 4 Dave Hyatt 2009-02-05 15:05:41 PST
Comment on attachment 27366 [details]
Revised patch

r=me
Comment 5 Simon Fraser (smfr) 2009-02-05 15:09:05 PST
http://trac.webkit.org/changeset/40685