Bug 237641 - [Selection] Fixes selection range settings for TEXTAREA
Summary: [Selection] Fixes selection range settings for TEXTAREA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zsun
URL:
Keywords: InRadar
: 207624 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-03-09 02:59 PST by zsun
Modified: 2022-04-28 20:29 PDT (History)
9 users (show)

See Also:

Attachments
Patch (38.94 KB, patch)
2022-03-09 03:18 PST, zsun 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (39.00 KB, patch)
2022-03-09 08:01 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (41.12 KB, patch)
2022-03-09 10:44 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (45.68 KB, patch)
2022-03-10 01:07 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (49.14 KB, patch)
2022-03-14 04:38 PDT, zsun 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (49.14 KB, patch)
2022-03-14 04:59 PDT, zsun 		no flags Details | Formatted Diff | Diff
Patch (49.12 KB, patch)
2022-03-15 02:41 PDT, zsun 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zsun 2022-03-09 02:59:45 PST 
A few WPT tests in imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection are affected.
Comment 1 zsun 2022-03-09 03:18:03 PST 
Created attachment 454220 [details]
Patch
Comment 2 zsun 2022-03-09 08:01:57 PST 
Created attachment 454237 [details]
Patch
Comment 3 zsun 2022-03-09 10:44:14 PST 
Created attachment 454269 [details]
Patch
Comment 4 zsun 2022-03-10 01:07:02 PST 
Created attachment 454322 [details]
Patch
Comment 5 zsun 2022-03-14 04:38:12 PDT 
Created attachment 454579 [details]
Patch
Comment 6 zsun 2022-03-14 04:59:34 PDT 
Created attachment 454581 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2022-03-14 08:56:19 PDT 
<rdar://problem/90248608>
Comment 8 Chris Dumez 2022-03-14 16:32:58 PDT 
Comment on attachment 454581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454581&action=review

r=me

> Source/WebCore/html/HTMLTextFormControlElement.cpp:316
> +    RefPtr<Frame> frame = document().frame();

RefPtr frame = document().frame();

> Source/WebCore/html/TextFieldInputType.cpp:148
> +        unsigned max = visibleValue().length();

nit: I would use auto.
Comment 9 zsun 2022-03-15 02:41:13 PDT 
Created attachment 454682 [details]
Patch
Comment 10 EWS 2022-03-17 02:20:40 PDT 
Committed r291396 (248526@main): <https://commits.webkit.org/248526@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454682 [details].
Comment 11 Arcady Goldmints-Orlov 2022-04-28 20:29:25 PDT 
*** Bug 207624 has been marked as a duplicate of this bug. ***