Bug 237630 - [Cocoa] metadata cue endTime may not be updated
Summary: [Cocoa] metadata cue endTime may not be updated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
: 239067 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-03-08 17:04 PST by Eric Carlson
Modified: 2022-05-03 22:27 PDT (History)
13 users (show)

See Also:


Attachments
Patch (9.69 KB, patch)
2022-03-08 17:17 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2022-03-08 17:04:50 PST
metadata cue endTime may not be updated
Comment 1 Eric Carlson 2022-03-08 17:04:55 PST
rdar://88690874
Comment 2 Eric Carlson 2022-03-08 17:17:10 PST
Created attachment 454179 [details]
Patch
Comment 3 Peng Liu 2022-03-08 17:23:47 PST
Comment on attachment 454179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review

> Source/WebCore/ChangeLog:10
> +        the next data cue from the same track starts. This means we donât know the 

Nit. "don't".

> Source/WebCore/ChangeLog:12
> +        given the end time of the media fileâs duration and the actual end time is updated

Nit. "media file's"?

> Source/WebCore/ChangeLog:22
> +        This means that if the media fileâs duration is not known when the text track list

Ditto.
Comment 4 Peng Liu 2022-03-08 17:25:39 PST
Comment on attachment 454179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review

> LayoutTests/http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html:20
> +                run('video.src = "http://127.0.0.1:8000/media/resources/hls/metadata/prog_index.m3u8"');

Is it possible to avoid using an absolute url here?
Comment 5 Eric Carlson 2022-03-08 17:41:19 PST
Comment on attachment 454179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review

>> Source/WebCore/ChangeLog:10
>> +        the next data cue from the same track starts. This means we donât know the 
> 
> Nit. "don't".

This is just create-pretty-print failing to deal with unicode.

>> LayoutTests/http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html:20
>> +                run('video.src = "http://127.0.0.1:8000/media/resources/hls/metadata/prog_index.m3u8"');
> 
> Is it possible to avoid using an absolute url here?

It is possible, but most of the http media tests use absolute urls so it doesn't seem necessary.
Comment 6 EWS 2022-03-08 19:35:33 PST
Committed r291029 (248203@main): <https://commits.webkit.org/248203@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454179 [details].
Comment 7 Eric Carlson 2022-04-19 06:47:21 PDT
*** Bug 239067 has been marked as a duplicate of this bug. ***
Comment 8 Ashutosh Kumar 2022-04-26 00:15:06 PDT
(In reply to Eric Carlson from comment #7)
> *** Bug 239067 has been marked as a duplicate of this bug. ***

Can you please let me know
In which version of Safari this fix will be available?
Comment 9 Ashutosh Kumar 2022-05-03 22:27:12 PDT
Could you please let me know which version of Safari this fix will be available?