Bug 237630 – [Cocoa] metadata cue endTime may not be updated

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

metadata cue endTime may not be updated

[Eric Carlson]

rdar://88690874

[Eric Carlson]

Created attachment 454179 [details]
Patch

[Peng Liu]

Comment on attachment 454179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review

> Source/WebCore/ChangeLog:10
> +        the next data cue from the same track starts. This means we donât know the 

Nit. "don't".

> Source/WebCore/ChangeLog:12
> +        given the end time of the media fileâs duration and the actual end time is updated

Nit. "media file's"?

> Source/WebCore/ChangeLog:22
> +        This means that if the media fileâs duration is not known when the text track list

Ditto.

[Peng Liu]

Comment on attachment 454179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review

> LayoutTests/http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html:20
> +                run('video.src = "http://127.0.0.1:8000/media/resources/hls/metadata/prog_index.m3u8"');

Is it possible to avoid using an absolute url here?

[Eric Carlson]

Comment on attachment 454179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review

>> Source/WebCore/ChangeLog:10
>> +        the next data cue from the same track starts. This means we donât know the 
> 
> Nit. "don't".

This is just create-pretty-print failing to deal with unicode.

>> LayoutTests/http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html:20
>> +                run('video.src = "http://127.0.0.1:8000/media/resources/hls/metadata/prog_index.m3u8"');
> 
> Is it possible to avoid using an absolute url here?

It is possible, but most of the http media tests use absolute urls so it doesn't seem necessary.

[EWS]

Committed r291029 (248203@main): <https://commits.webkit.org/248203@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454179 [details].

[Eric Carlson]

*** Bug 239067 has been marked as a duplicate of this bug. ***

[Ashutosh Kumar]

(In reply to Eric Carlson from comment #7)
> *** Bug 239067 has been marked as a duplicate of this bug. ***

Can you please let me know
In which version of Safari this fix will be available?

[Ashutosh Kumar]

Could you please let me know which version of Safari this fix will be available?