WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237627
Combine Lookup and Define.
https://bugs.webkit.org/show_bug.cgi?id=237627
Summary
Combine Lookup and Define.
Megan Gardner
Reported
2022-03-08 16:09:56 PST
Combine Lookup and Define.
Attachments
Patch
(1.71 KB, patch)
2022-03-08 16:10 PST
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2022-03-08 16:10:49 PST
Created
attachment 454169
[details]
Patch
Megan Gardner
Comment 2
2022-03-08 16:10:54 PST
<
rdar://problem/26205225
>
Tim Horton
Comment 3
2022-03-08 16:14:34 PST
Comment on
attachment 454169
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=454169&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-4243 > - MCProfileConnection *connection = [PAL::getMCProfileConnectionClass() sharedConnection]; > - if ([connection effectiveBoolValueForSetting:PAL::get_ManagedConfiguration_MCFeatureDefinitionLookupAllowed()] == MCRestrictedBoolExplicitNo)
Funny that I don't see equivalent code in _lookupForWebView. Still, since this was dead code until a recent change, we should be OK. Maybe Lookup does it internally?
EWS
Comment 4
2022-03-09 23:06:17 PST
Committed
r291091
(
248253@main
): <
https://commits.webkit.org/248253@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 454169
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug