Bug 237592 - Remove RemoteVideoSample
Summary: Remove RemoteVideoSample
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-08 03:02 PST by youenn fablet
Modified: 2022-03-10 01:10 PST (History)
11 users (show)

See Also:


Attachments
Patch (42.01 KB, patch)
2022-03-08 03:04 PST, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (42.00 KB, patch)
2022-03-08 04:16 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (44.44 KB, patch)
2022-03-08 08:40 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (44.59 KB, patch)
2022-03-08 08:46 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (37.79 KB, patch)
2022-03-09 23:06 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-03-08 03:02:20 PST
Remove RemoteVideoSample
Comment 1 youenn fablet 2022-03-08 03:04:25 PST
Created attachment 454091 [details]
Patch
Comment 2 youenn fablet 2022-03-08 04:16:55 PST
Created attachment 454100 [details]
Patch
Comment 3 Eric Carlson 2022-03-08 08:10:12 PST
Comment on attachment 454100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454100&action=review

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:110
> +        connection->send(Messages::LibWebRTCCodecs::CompletedDecodingCV { identifier, timeStamp, pixelBuffer, MediaTime(timeStampNs, 1) }, 0);

I see this isn't new, but do you mean to create a MediaTime with a timescale of 1?
Comment 4 youenn fablet 2022-03-08 08:40:52 PST
Created attachment 454125 [details]
Patch
Comment 5 youenn fablet 2022-03-08 08:46:26 PST
Created attachment 454126 [details]
Patch
Comment 6 youenn fablet 2022-03-08 08:49:29 PST
(In reply to Eric Carlson from comment #3)
> Comment on attachment 454100 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454100&action=review
> 
> > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:110
> > +        connection->send(Messages::LibWebRTCCodecs::CompletedDecodingCV { identifier, timeStamp, pixelBuffer, MediaTime(timeStampNs, 1) }, 0);
> 
> I see this isn't new, but do you mean to create a MediaTime with a timescale
> of 1?

Good point, fixing it in the latest patch.
Comment 7 EWS 2022-03-09 11:22:39 PST
Tools/Scripts/svn-apply failed to apply attachment 454126 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 youenn fablet 2022-03-09 23:06:02 PST
Created attachment 454319 [details]
Patch for landing
Comment 9 EWS 2022-03-10 01:09:10 PST
Committed r291095 (248257@main): <https://commits.webkit.org/248257@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454319 [details].
Comment 10 Radar WebKit Bug Importer 2022-03-10 01:10:17 PST
<rdar://problem/90085513>