Bug 237580 - Expand adattributiond sandbox to prevent sandbox exceptions during main functionality
Summary: Expand adattributiond sandbox to prevent sandbox exceptions during main funct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-07 21:06 PST by Alex Christensen
Modified: 2022-03-08 09:16 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2022-03-07 21:07 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-03-07 21:06:32 PST 
Expand adattributiond sandbox to prevent sandbox exceptions during main functionality
Comment 1 Alex Christensen 2022-03-07 21:07:20 PST 
Created attachment 454070 [details]
Patch
Comment 2 Alex Christensen 2022-03-07 21:07:24 PST 
<rdar://problem/89855243>
Comment 3 Per Arne Vollan 2022-03-08 07:31:31 PST 
Comment on attachment 454070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454070&action=review

R=me.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:125
> +        "com.apple.containermanagerd"

I don't think this is strictly needed. Can you do without it?
Comment 4 Alex Christensen 2022-03-08 09:00:18 PST 
Comment on attachment 454070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454070&action=review

>> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:125
>> +        "com.apple.containermanagerd"
> 
> I don't think this is strictly needed. Can you do without it?

Maybe, but there were sandbox violations without it and all our other processes have it.  I'm going to add it for now and we can consider removing it in the future with the others.
Comment 5 EWS 2022-03-08 09:16:42 PST 
Committed r290996 (248174@main): <https://commits.webkit.org/248174@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454070 [details].