RESOLVED WORKSFORME23757
[Gtk] window.open() is failed and Image is not displayed. 
https://bugs.webkit.org/show_bug.cgi?id=23757
Summary [Gtk] window.open() is failed and Image is not displayed.
Paanky
Reported 2009-02-05 04:47:25 PST
Lunch the browser through GtkLuncher. Fetch the page "http://www.hdfcbank.com". See the login button is not displayed. Instead a small square is displayed in its place. Click the square it should display a new page. The new page is displayed through javascript "window.open()" method. But in WebKit it fails. The revision id is : 40471.
Attachments
Add attachment proposed patch, testcase, etc.
Paanky
Comment 1 2009-02-05 04:56:19 PST
In "JSValuePtr windowProtoFuncOpen(ExecState* exec, JSObject*, JSValuePtr thisValue, const ArgList& args)" function, "if (topOrParent)" is checked. But topParent is asigned true, only when frameName is "_top" or "_parent" or non-empty. But it may happen that frameName can be empty as in case of this "http://www.hdfcbank.com" site. Would like to know why the log-in button image is not displaying.
Kalle Vahlman
Comment 2 2009-03-26 10:18:23 PDT
(In reply to comment #1) > Would like to know why the log-in button image is not displaying. Probably because of this: new_login.gif: PC bitmap, Windows 3.x format, 69 x 24 x 8 It's not actually a GIF file so WebKit fails to decode it. As for the window.open() thing, clicking on the login button does open a big window here.
Paanky
Comment 3 2009-03-26 21:51:43 PDT
(In reply to comment #2) > (In reply to comment #1) > > Would like to know why the log-in button image is not displaying. > > Probably because of this: > > new_login.gif: PC bitmap, Windows 3.x format, 69 x 24 x 8 > > It's not actually a GIF file so WebKit fails to decode it. > > As for the window.open() thing, clicking on the login button does open a big > window here. > As I have said above it fails due to the implementation behavior. Just try avoid checking the above said "_top" or "_parent" frameName check in "JSValuePtr windowProtoFuncOpen(ExecState* exec, JSObject*, JSValuePtr thisValue, const ArgList& args)" function. And see that it will load fine.
Jan Alonzo
Comment 4 2009-07-07 06:15:47 PDT
This seems to be fixed in r455xx (or maybe even fixed in earlier revisions). Please reopen if the problem still exist. Thanks.
Note You need to log in before you can comment on or make changes to this bug.