Bug 237556 - Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS
Summary: Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-07 14:13 PST by David Kilzer (:ddkilzer)
Modified: 2022-03-07 19:01 PST (History)
2 users (show)

See Also:

Attachments
Patch v1 (1.73 KB, patch)
2022-03-07 14:15 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-03-07 14:13:40 PST 
Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS.

If this is not defined, errors like this occur when building Release with lower optimization levels:

    Source/WTF/wtf/Compiler.h:103:2: error: "Building release without compiler optimizations: WebKit will be slow. Set -DRELEASE_WITHOUT_OPTIMIZATIONS if this is intended."
Comment 1 Radar WebKit Bug Importer 2022-03-07 14:13:57 PST 
<rdar://problem/89929061>
Comment 2 David Kilzer (:ddkilzer) 2022-03-07 14:15:11 PST 
Created attachment 454034 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2022-03-07 16:40:45 PST 
Comment on attachment 454034 [details]
Patch v1

cq+ since this doesn't affect non-sanitizer builds.
Comment 4 EWS 2022-03-07 19:01:52 PST 
Committed r290970 (248149@main): <https://commits.webkit.org/248149@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454034 [details].