Bug 237546 - skip scheduling lazy UA shadow tree creation if already created or not needed
Summary: skip scheduling lazy UA shadow tree creation if already created or not needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-07 12:17 PST by Cameron McCormack (:heycam)
Modified: 2022-03-08 19:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2022-03-08 12:02 PST, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2022-03-08 12:15 PST, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-03-07 12:17:48 PST 
Bug 236747 made <input> element UA shadow trees get created lazily.  HTMLInputElement::insertedIntoAncestor now schedules the UA shadow tree to be created the next time style is flushed.  We currently do this every time an <input> element is inserted into the document, but there's only a need to do this if the particular input type needs a shadow tree and we haven't already created it.
Comment 1 Radar WebKit Bug Importer 2022-03-07 12:19:18 PST 
<rdar://problem/89922896>
Comment 2 Cameron McCormack (:heycam) 2022-03-08 12:02:19 PST 
Created attachment 454140 [details]
Patch
Comment 3 Aditya Keerthi 2022-03-08 12:11:38 PST 
Comment on attachment 454140 [details]
Patch

Might be helpful to put your comment in the bug description in the ChangeLog file.
Comment 4 Cameron McCormack (:heycam) 2022-03-08 12:15:15 PST 
Created attachment 454142 [details]
Patch
Comment 5 EWS 2022-03-08 19:00:09 PST 
Committed r291028 (248202@main): <https://commits.webkit.org/248202@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454142 [details].