Bug 237521 - makeprop.pl breaks reproducible builds
Summary: makeprop.pl breaks reproducible builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-07 03:33 PST by Alberto Garcia
Modified: 2022-07-07 13:02 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2022-03-07 03:41 PST, Alberto Garcia 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2022-03-07 03:33:11 PST 
I'm trying to make the WebKit build reproducible, and one problem that I've found is that the CSSPropertyNames.cpp file generated by makeprop.pl is different in each build.

The reason is the way makeprop.pl iterates over the contents of hashes, which by definition are not guaranteed to have a stable order in Perl.

Fortunately this is easy to solve, I'm uploading a patch.
Comment 1 Alberto Garcia 2022-03-07 03:41:42 PST 
Created attachment 453959 [details]
Patch
Comment 2 EWS 2022-03-07 04:44:44 PST 
Committed r290883 (248114@main): <https://commits.webkit.org/248114@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453959 [details].
Comment 3 Radar WebKit Bug Importer 2022-03-07 04:45:16 PST 
<rdar://problem/89899805>