We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and manually add what we need instead.
Created attachment 453956 [details] Patch
Comment on attachment 453956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453956&action=review > Tools/wpe/manifest.txt.in:-50 > -exclude Source/ThirdParty/capstone We may want to keep the capstone subdirectory because the JSCOnly uses it unconditionally, and removing it would make it impossible to build JSCOnly from our release tarballs. OTOH, many Linux distributions have packages for Capstone, so we may be able to link against system libraries and avoid the bundling 🤔️
I guess nobody have ever tried to build jsconly from a tarball then. In any case, I think it's better not to change the behavior in this patch.
Comment on attachment 453956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453956&action=review > Tools/gtk/manifest.txt.in:62 > +directory Source/ThirdParty/gtest Another random note: I'm not sure this actually works from tarball builds. The tests that use gtest probably require other stuff that's not in the tarballs. Investigating that has been on my TODO for years. :P I agree it's best not to change behavior in this patch, though.
(In reply to Carlos Garcia Campos from comment #3) > I guess nobody have ever tried to build jsconly from a tarball then. In any > case, I think it's better not to change the behavior in this patch. I built JSCOnly a few times in the past (around the 2.30.x - 2.32.x series) and it used to work, but I haven't tried in a while.
(In reply to Adrian Perez from comment #5) > (In reply to Carlos Garcia Campos from comment #3) > > I guess nobody have ever tried to build jsconly from a tarball then. In any > > case, I think it's better not to change the behavior in this patch. > > I built JSCOnly a few times in the past (around the 2.30.x - 2.32.x series) > and it used to work, but I haven't tried in a while. I just tried building JSCOnly using the sources from the WPE WebKit 2.34.6 release tarball and it worked fine :] OTOH we never had made the promise that this would work, so ¯\_(ツ)_/¯
Committed r290982 (248160@trunk): <https://commits.webkit.org/248160@trunk>