Bug 237510 – Add options to filter generate-compile-commands output

• Status: NEW
• Component: Tools / Tests

[Brandon]

Add options to filter generate-compile-commands output

[Brandon]

Created attachment 453944 [details]
patch

[Brandon]

The generate-compile-commands generates data for all sources compiled (except third party), however, users may only care about a subset of the files. This allows users to output a more focused compile_commands.json with only the directories they care about. Passing no parameters will output all sources like before.

How to use:
generate-compile-commands WebKitBuild/Debug/ --exclude_bmalloc --exclude_jsc

This will filter out the bmalloc and JavaScriptCore directories from compile_commands.json.

[Alexey Proskuryakov]

It's not really clear to me when one would what to exclude specific directories. I believe you that there is a use case, but it's hard to me to comment without understanding it.

In the department on bike shed painting, I think that the names should use dashes, not underscores. Or alternatively, --exclude wtf,jsc,tools

[Elliott Williams]

I would love to not have a hard-coded list of projects in here. Can you do this while matching path or target names in a more generic way?

My understanding of the problem is that we emit so much build metadata that clangd is sluggish, and the recommended solution is to skip merging compile commands from third-party sources. This feels like a reasonable default. Could we do automatically so that engineers don't have to know about these options?

Also, I'm curious if our cmake-based ports have a similar problem with clangd, and if so, whether they've done anything to address it.

[Radar WebKit Bug Importer]

<rdar://problem/90230511>