Bug 237506 – [GTK] generate-automation-atom.py breaks reproducible builds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

Running this a few times in a row produces different output files:

$ python3 Source/WebKit/Scripts/generate-automation-atom.py ./Source/WebKit/UIProcess/Automation/atoms/FindNodes.js out.js

All generated files are equally valid and there are no semantic changes, it's just that the functions appear in different order.

This results in different WebKitWebDriver binaries and therefore makes the builds non reproducible.

[Adrian Perez]

Created attachment 453933 [details]
Patch

[Michael Catanzaro]

Comment on attachment 453933 [details]
Patch

Did this somehow break webkitpy tests, or is the EWS busted even without your patch?

[Adrian Perez]

Created attachment 453966 [details]
Patch v2

[Alberto Garcia]

Comment on attachment 453966 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=453966&action=review

> Source/WebKit/Scripts/generate-automation-atom.py:55
>  def append_functions(utils_data, util_functions, util_functions_impl, functions_written):
> +    util_functions_list = list(util_functions)
> +    util_functions_list.sort()
>      for function in util_functions:

You forgot to actually use util_functions_list in the for loop

[Adrian Perez]

(In reply to Alberto Garcia from comment #4)
> Comment on attachment 453966 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453966&action=review
> 
> > Source/WebKit/Scripts/generate-automation-atom.py:55
> >  def append_functions(utils_data, util_functions, util_functions_impl, functions_written):
> > +    util_functions_list = list(util_functions)
> > +    util_functions_list.sort()
> >      for function in util_functions:
> 
> You forgot to actually use util_functions_list in the for loop

Of course 🤦️; I'll fix that before landing.

[Adrian Perez]

Created attachment 453979 [details]
Patch for landing

[EWS]

Committed r290890 (248121@main): <https://commits.webkit.org/248121@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453979 [details].