Running this a few times in a row produces different output files: $ python3 Source/WebKit/Scripts/generate-automation-atom.py ./Source/WebKit/UIProcess/Automation/atoms/FindNodes.js out.js All generated files are equally valid and there are no semantic changes, it's just that the functions appear in different order. This results in different WebKitWebDriver binaries and therefore makes the builds non reproducible.
Created attachment 453933 [details] Patch
Comment on attachment 453933 [details] Patch Did this somehow break webkitpy tests, or is the EWS busted even without your patch?
Created attachment 453966 [details] Patch v2
Comment on attachment 453966 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=453966&action=review > Source/WebKit/Scripts/generate-automation-atom.py:55 > def append_functions(utils_data, util_functions, util_functions_impl, functions_written): > + util_functions_list = list(util_functions) > + util_functions_list.sort() > for function in util_functions: You forgot to actually use util_functions_list in the for loop
(In reply to Alberto Garcia from comment #4) > Comment on attachment 453966 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453966&action=review > > > Source/WebKit/Scripts/generate-automation-atom.py:55 > > def append_functions(utils_data, util_functions, util_functions_impl, functions_written): > > + util_functions_list = list(util_functions) > > + util_functions_list.sort() > > for function in util_functions: > > You forgot to actually use util_functions_list in the for loop Of course 🤦️; I'll fix that before landing.
Created attachment 453979 [details] Patch for landing
Committed r290890 (248121@main): <https://commits.webkit.org/248121@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453979 [details].