Bug 237504 – Fix JITOperationList::addPointers() to support JIT_OPERATION_VALIDATION_ASSERT_ENABLED.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

According to tagJSCCodePtrImpl(), we will only use an operation's validation entry if Options::useJITCage().  Make JITOperationList::addPointers() conform to this.

<rdar://problem/89770507>

[Mark Lam]

Created attachment 453923 [details]
[fast-cq] proposed patch.

[Saam Barati]

Comment on attachment 453923 [details]
[fast-cq] proposed patch.

r=me

[Mark Lam]

The 2 failing tests on the Win EWS are:
- fast/dom/connected-subframe-counter-overflow.html
- fast/frames/exponential-frames.html

According to: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fconnected-subframe-counter-overflow.html and https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fexponential-frames.htm, the first is a flaky on Win10, and the second crashes all the time in recent builds.

Also, this patch only populates a HashMap that is only used on Debug build.  The Win EWS is running with a Release build.

This patch only takes effect on ARM64E CPUs.  The Win EWS runs on x86.

Hence, these failures cannot be due to this patch.

[Mark Lam]

Comment on attachment 453923 [details]
[fast-cq] proposed patch.

Thanks for the review.  Landing now.

[EWS]

Committed r290873 (248104@main): <https://commits.webkit.org/248104@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453923 [details].