237493 – [iOS] Flash media controls when a fullscreen video resets its source

Bug 237493 - [iOS] Flash media controls when a fullscreen video resets its source

Summary: [iOS] Flash media controls when a fullscreen video resets its source

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Peng Liu

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-03-04 20:29 PST by Peng Liu
Modified:	2022-03-08 09:30 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (4.19 KB, patch) 2022-03-04 20:51 PST, Peng Liu	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
Fix build failures on watchOS (4.28 KB, patch) 2022-03-04 21:20 PST, Peng Liu	no flags	Details \| Formatted Diff \| Diff
Fix build failures (4.62 KB, patch) 2022-03-07 13:24 PST, Peng Liu	jer.noble: review+ ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
[fast-cq] Patch for landing (5.65 KB, patch) 2022-03-07 17:00 PST, Peng Liu	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peng Liu 2022-03-04 20:29:06 PST

Flash media controls when a fullscreen video resets its source

Comment 1 Peng Liu 2022-03-04 20:51:49 PST

Created attachment 453894 [details]
Patch

Comment 2 Peng Liu 2022-03-04 20:52:37 PST

<rdar://79950080>

Comment 3 Peng Liu 2022-03-04 21:20:35 PST

Created attachment 453897 [details]
Fix build failures on watchOS

Comment 4 Peng Liu 2022-03-07 13:24:39 PST

Created attachment 454022 [details]
Fix build failures

Comment 5 Jer Noble 2022-03-07 16:32:14 PST

Comment on attachment 454022 [details]
Fix build failures

View in context: https://bugs.webkit.org/attachment.cgi?id=454022&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:100
> +#if !PLATFORM(WATCHOS)
> +- (void)flashPlaybackControlsWithDuration:(NSTimeInterval)duration;
> +#endif

Nit: let's move this into the AVKitSPI.h header.

Comment 6 Peng Liu 2022-03-07 17:00:16 PST

Created attachment 454053 [details]
[fast-cq] Patch for landing

Comment 7 EWS 2022-03-08 09:30:25 PST

Committed r290997 (248175@main): <https://commits.webkit.org/248175@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454053 [details].