RESOLVED FIXED 237493
[iOS] Flash media controls when a fullscreen video resets its source 
https://bugs.webkit.org/show_bug.cgi?id=237493
Summary [iOS] Flash media controls when a fullscreen video resets its source
Peng Liu
Reported 2022-03-04 20:29:06 PST
Flash media controls when a fullscreen video resets its source
Attachments
Patch (4.19 KB, patch)
2022-03-04 20:51 PST, Peng Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Fix build failures on watchOS (4.28 KB, patch)
2022-03-04 21:20 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Fix build failures (4.62 KB, patch)
2022-03-07 13:24 PST, Peng Liu 		jer.noble: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (5.65 KB, patch)
2022-03-07 17:00 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2022-03-04 20:51:49 PST
Created attachment 453894 [details] Patch
Peng Liu
Comment 2 2022-03-04 20:52:37 PST
<rdar://79950080>
Peng Liu
Comment 3 2022-03-04 21:20:35 PST
Created attachment 453897 [details] Fix build failures on watchOS
Peng Liu
Comment 4 2022-03-07 13:24:39 PST
Created attachment 454022 [details] Fix build failures
Jer Noble
Comment 5 2022-03-07 16:32:14 PST
Comment on attachment 454022 [details] Fix build failures View in context: https://bugs.webkit.org/attachment.cgi?id=454022&action=review > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:100 > +#if !PLATFORM(WATCHOS) > +- (void)flashPlaybackControlsWithDuration:(NSTimeInterval)duration; > +#endif Nit: let's move this into the AVKitSPI.h header.
Peng Liu
Comment 6 2022-03-07 17:00:16 PST
Created attachment 454053 [details] [fast-cq] Patch for landing
EWS
Comment 7 2022-03-08 09:30:25 PST
Committed r290997 (248175@main): <https://commits.webkit.org/248175@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454053 [details].
Note You need to log in before you can comment on or make changes to this bug.