Bug 237491 - Remove unnecessary Async attribute in .messages.in files
Summary: Remove unnecessary Async attribute in .messages.in files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-04 18:12 PST by Alex Christensen
Modified: 2022-03-07 13:01 PST (History)
13 users (show)

See Also:

Attachments
Patch (218.68 KB, patch)
2022-03-04 18:13 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (218.58 KB, patch)
2022-03-07 09:39 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (299.04 KB, patch)
2022-03-07 11:08 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-03-04 18:12:07 PST 
Remove unnecessary Async attribute in .messages.in files
Comment 1 Alex Christensen 2022-03-04 18:13:01 PST 
Created attachment 453885 [details]
Patch
Comment 2 Chris Dumez 2022-03-04 22:04:31 PST 
Comment on attachment 453885 [details]
Patch

r- because EWS failures look real.
Comment 3 Alex Christensen 2022-03-07 09:39:30 PST 
Created attachment 453996 [details]
Patch
Comment 4 Alex Christensen 2022-03-07 11:08:45 PST 
Created attachment 454004 [details]
Patch
Comment 5 Alex Christensen 2022-03-07 11:34:31 PST 
The test expectations change because there are some test messages.in files that contained unannotated messages with replies, such as TestWithLegacyReceiver.CreatePlugin, which were assumed to be synchronous and now are assumed to be async.  I programmatically verified that no non-test message receivers were like this, and I verified that the output is binary equal before and after this change.
Comment 6 Chris Dumez 2022-03-07 12:12:46 PST 
Comment on attachment 454004 [details]
Patch

r=me assuming the bots are happy.
Comment 7 EWS 2022-03-07 13:00:16 PST 
Committed r290903 (248134@main): <https://commits.webkit.org/248134@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454004 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-07 13:01:18 PST 
<rdar://problem/89924967>