Fix for <select> elements in isolated tree mode.
rdar://89530022
Created attachment 453867 [details] Patch
Comment on attachment 453867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453867&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:3417 > + case AXMenuListValueChanged: This will cause the entire node to be re-computed (tree->updateNode(*notification.first)). Is there more fine-grained set of properties that we can re-compute via tree->updateNodeProperty instead? I doubt people will be changing menu list values often enough for this to be a performance problem, so if we don't want to spend the time investigating this now it's fine. Just curious if you looked into this.
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 453867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453867&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:3417 > > + case AXMenuListValueChanged: > > This will cause the entire node to be re-computed > (tree->updateNode(*notification.first)). Is there more fine-grained set of > properties that we can re-compute via tree->updateNodeProperty instead? > > I doubt people will be changing menu list values often enough for this to be > a performance problem, so if we don't want to spend the time investigating > this now it's fine. Just curious if you looked into this. I considered this valid point, and there may be other properties besides the value that we need to update. We may refine if need be in a second pass based on the role and the properties that can be affected.
Created attachment 453978 [details] Patch
Committed r290965 (248145@main): <https://commits.webkit.org/248145@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453978 [details].