Bug 237456 - [Cocoa] Crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL
Summary: [Cocoa] Crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-03 16:46 PST by Eric Carlson
Modified: 2022-03-04 10:47 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2022-03-03 17:05 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (5.89 KB, patch)
2022-03-03 17:12 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (5.90 KB, patch)
2022-03-03 17:31 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2022-03-03 16:46:40 PST 
Sometimes see a crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL when creating an AtomString from a compile-time const char*
Comment 1 Eric Carlson 2022-03-03 16:46:59 PST 
rdar://80407863
Comment 2 Eric Carlson 2022-03-03 17:05:22 PST 
Created attachment 453797 [details]
Patch
Comment 3 Eric Carlson 2022-03-03 17:12:26 PST 
Created attachment 453799 [details]
Patch
Comment 4 Jer Noble 2022-03-03 17:15:49 PST 
Comment on attachment 453799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453799&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:1082
> +bool MediaPlayerPrivateAVFoundation::enableInheritURIQueryComponent() const

Nit: maybe shouldEnableInheritURIQueryComponent()?
Comment 5 Eric Carlson 2022-03-03 17:31:04 PST 
Created attachment 453801 [details]
Patch for landing
Comment 6 EWS 2022-03-04 10:47:30 PST 
Committed r290837 (248073@main): <https://commits.webkit.org/248073@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453801 [details].