Bug 237455 – IDB serialization thread should pass isolated copy of IndexIDToIndexKeyMap to storage thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Sihui Liu]

...

[Sihui Liu]

Created attachment 453792 [details]
Patch

[Sihui Liu]

Created attachment 453798 [details]
Patch

[Chris Dumez]

Comment on attachment 453798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453798&action=review

r=me with improvement suggestion

> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506
> +        indexKeys.add(entry.key, indexKey.isolatedCopy());

I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String) have special optimizations when isolatedCopy() is called on a r-value expression.

[Sihui Liu]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 453798 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453798&action=review
> 
> r=me with improvement suggestion
> 
> > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506
> > +        indexKeys.add(entry.key, indexKey.isolatedCopy());
> 
> I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String)
> have special optimizations when isolatedCopy() is called on a r-value
> expression.

Sure, will change.

[Sihui Liu]

Created attachment 453848 [details]
Patch for landing

[EWS]

Committed r290836 (248072@main): <https://commits.webkit.org/248072@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453848 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89820257>